security(lottie): validate postMessage origin on web HTML renderer#2294
Draft
cursor[bot] wants to merge 1 commit into
Draft
security(lottie): validate postMessage origin on web HTML renderer#2294cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The Lottie web HTML renderer listened for window messages without checking event.origin and used wildcard postMessage targets. A cross-origin page with a window reference could spoof onComplete/onForward callbacks and trigger YAML-defined actions. Restrict iframe and host traffic to the app origin and add regression tests. Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/application-security-review-e7e2
branch
from
c9c4e28 to
2eb3662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vulnerability summary
The Lottie web HTML renderer listened for
window.postMessageevents without checkingevent.originand used wildcard ("*") targets when posting back to the parent frame. A cross-origin page with awindowreference to the Ensemble app could spoofonComplete/onForwardcallbacks and trigger YAML-defined actions.Affected location
modules/ensemble/lib/widget/lottie/web/lottiestate.dartSecurity impact
Severity: Medium
window.open) or otherwise holds a reference to its window.ScreenController().executeAction()runs configured YAML callbacks.Fix approach
Restrict iframe ↔ host
postMessagetraffic to the app origin and validate incoming message origins before dispatching callbacks.Tests
modules/ensemble/test/lottie_post_message_test.dart